Author |
Message |
Henri Beauchamp
Joined: 2009-03-17 18:42:51 Posts: 5523
|
OK, I came up with a more elaborate patch (attached), to use against the clean v1.30.2.5 sources.
Try it "as is" (it will try and enable OpenGL v3.2 core profile, with GLSL v140).
If it does not work, reapply it to clean sources, and before launching the compilation, edit linden/indra/cmake/00-BuildOptions.cmake to change line 73 to "set(USE_DARWIN_GL3 OFF)": it will then compile a viewer version with old OpenGL v2.1 compatibility profile and the old vertex buffers code from v1.30.2.3, and should hopefully work like the latter did...
|
2023-03-13 23:07:54 |
|
|
linyifei
Joined: 2012-01-19 03:18:40 Posts: 196 Location: Sydney, Australia (UTC +10)
|
I'm sorry, Henri, but I'm not sure how to do this, despite reading several articles on diff and patch. Could you provide some instructions please? Bear in mind that I only learned out how to build my own Cool VL Viewer from your sources last December. Edit: I'm sorry, I just realised that you did provide instructions earlier in this thread. I'll have a go tonight.
|
2023-03-14 10:58:57 |
|
|
linyifei
Joined: 2012-01-19 03:18:40 Posts: 196 Location: Sydney, Australia (UTC +10)
|
I did this, but it crashed on startup. Logs attached in CoolVLViewer1.30.2.5-patch-v2.zip I did this, but it crashed on startup too. Logs attached in CoolVLViewer1.30.2.5-patch-v2+USE_DARWIN_GL3 OFF
|
2023-03-14 12:54:14 |
|
|
Henri Beauchamp
Joined: 2009-03-17 18:42:51 Posts: 5523
|
Same crash in both cases (and same crash as without any patch)...
EDIT: I may be found a potential issue. Scratch everything else: too many small changes went into viewer PBR, and I must resync everything... Will give you two a link to beta sources to try and compile from.
|
2023-03-14 13:35:31 |
|
|
Henri Beauchamp
Joined: 2009-03-17 18:42:51 Posts: 5523
|
OK, this time I think I nailed it... In v1.30.2.5 (or .4), simply remove the following block of code in linden/indra/newview/llvovolume.cpp, from lines 6295 to 6304: This causes the code to fall back to the non-VBO path that got removed !
|
2023-03-14 23:01:01 |
|
|
linyifei
Joined: 2012-01-19 03:18:40 Posts: 196 Location: Sydney, Australia (UTC +10)
|
Yes! I built 1.30.2.5 with this fix, and it started up just fine! Thank you Henri for nailing this one!
|
2023-03-15 11:01:03 |
|
|
Henri Beauchamp
Joined: 2009-03-17 18:42:51 Posts: 5523
|
While this bug was a real PITA (I was searching for a bug in my code, when the problem was caused by an old workaround by someone else), its resolution incidentally also brought OpenGL v3.2 support for macOS, which will be enabled in next release...
|
2023-03-15 14:48:51 |
|
|
Catten
Joined: 2011-09-17 11:12:19 Posts: 360
|
Yep I can confirm that it's fixed. Thank you Henri, that was a tough one.
|
2023-03-15 16:46:50 |
|
|
Henri Beauchamp
Joined: 2009-03-17 18:42:51 Posts: 5523
|
Today's release (v1.30.2.6) got the fixes implemented and should therefore work again under macOS...
Note that OpenGL v3.2 core profile is enabled by default in the sources; if you need to disable it (i.e. should it cause any rendering issue), you can do so by setting USE_DARWIN_GL3 to OFF, line 74 of linden/indra/cmake/00-BuildOptions.cmake before compiling the viewer (and please, do report any such issue).
|
2023-03-18 10:08:24 |
|
|