Cool VL Viewer forum
http://sldev.free.fr/forum/

Cool VL Viewer v1.30.2.15 crashed on taking snapshot.
http://sldev.free.fr/forum/viewtopic.php?f=4&t=2367		 Page 1 of 1
Author:  linyifei [ 2023-06-05 00:05:58 ]
Post subject:  Cool VL Viewer v1.30.2.15 crashed on taking snapshot.
Cool VL Viewer v1.30.2.15 crashed on taking a snapshot to my local hard disk this morning, and I have attached the viewer log and crash dump below. I have had this intermittent problem for years, going back over many releases of the viewer, and in the past ignored it and logged back in, but with my new policy of reporting all crashes, here we are.

This was the first snapshot of my viewer session (that is always when it seems to happen), so when I pressed Ctrl-` I got the usual dialogue prompting me to enter a file-name, so I typed 20230605 (my normal naming convention is to prefix my snapshot files with the date) and pressed Return. The viewer "beachballed" and then crashed. Testing suggests that the viewer does not crash if instead of just pressing Return after entering the date, I mouse-click on the OK button.

Attachments:
Cool VL Viewer_2023-06-05.zip [38.49 KiB]
Downloaded 60 times
Author:  Henri Beauchamp [ 2023-06-05 08:50:57 ]
Post subject:  Re: Cool VL Viewer v1.30.2.15 crashed on taking snapshot.
Thank you very much for the crash report !

There is indeed something fishy happening between snapshot taking and the file selector, due to the fact the latter gets redrawn during the snapshot it triggers when you choose a file: even under Linux, when using the RETURN key instead of the OK button (or a double-click on a file), I get a black snapshot image... But under macOS, due to how the draw loop is handled under this OS, it causes an infinite loop instead (and a crash after the return stack has filled up to the brim) !

I changed the way the RETURN key callback is dealt with, and how the file selector gets closed to avoid any other such issues in the future (the file selector is now hidden on any selection method type, and is actually closed at the next idle loop only, which cannot happen during UI redrawing).

Here is a patch you could test on your side to let me know if it also fixes things for you (and macOS):
Attachment:
snapshot_to_disk_fix-patch.txt [2.67 KiB]
Downloaded 59 times
Author:  Henri Beauchamp [ 2023-06-10 09:25:30 ]
Post subject:  Re: Cool VL Viewer v1.30.2.15 crashed on taking snapshot.
Fixed in today's release.
Page 1 of 1 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/