Cool VL Viewer forum
http://sldev.free.fr/forum/

PBR and sun/avatar 'rez cloud' issue?
http://sldev.free.fr/forum/viewtopic.php?f=4&t=2451		 Page 1 of 1
Author:  ZaneZimer [ 2024-01-15 15:10:55 ]
Post subject:  PBR and sun/avatar 'rez cloud' issue?
I'm wondering if anyone has seen any issue with the Sun texture when PBR is enabled. It seems to be a semi-transparent darker disk in the bright 'corona' at the sun's position. I have also noted, though maybe unrelated, that the cloud texture used during avatar rez from login or teleport has a 'square-ness' about it. The effect on the avatar rez cloud is very subtle but more visible at 'night'. Isn't as clear in my uploaded images, however. :-/

I have used the official build for the image capture:
Code:
Cool VL Viewer v1.32.0.5, Jan  6 2024 09:30:23
Release notes

You are at 277768.9, 255912.1, 22.0  in Muddy Run located at
simhost-009c4df455c10cc53.agni.secondlife.io (35.89.163.136:13020)
Alias: ec2-35-89-163-136.us-west-2.compute.amazonaws.com
Second Life Server 2023-11-07.6790647783
Release notes

CPU: AMD Ryzen 7 3700X 8-Core Processor (4378 MHz)
Memory: 64217MB
OS version: Linux-x86_64 v6.6.9-200.fc39.x86_64
Memory manager: jemalloc v5.3.1-20231028
Graphics: NVIDIA GEFORCE GTX 1080 TI/PCIE/SSE2
OpenGL version: 4.6.0 NVIDIA 545.29.06
Detected VRAM: 11264MB
J2C decoder: OpenJPEG: 1.4.0.635f
Audio driver: OpenAL v1.1 ALSOFT 1.23.1 (OpenAL Soft: OpenAL Soft)
Networking backend: libcurl 7.47.0/OpenSSL 1.0.2u/zlib 1.2.13.zlib-ng
Browser plugin: Dullahan 1.13.2/CEF 120.1.8/Chromium 120.0.6099.109
Packets lost: 0/3394 (0.0%)

Built with: GCC v8.3.0
Compiler-generated maths: SSE2.

Compile flags used for this build:
-O3 -fno-delete-null-pointer-checks -fno-ipa-cp-clone -fno-align-labels -fno-align-loops -fsched-pressure -frename-registers -fweb -fira-hoist-pressure -DNDEBUG -std=c++17 -fno-stack-protector -U_FORTIFY_SOURCE -fno-threadsafe-statics -fPIC -pipe -g -gdwarf-4 -fno-var-tracking-assignments -fexceptions -fno-strict-aliasing -fvisibility=hidden -fsigned-char -m64 -mfpmath=sse -fno-math-errno -fno-trapping-math -pthread  -DLL_LINUX=1 -DLL_JEMALLOC=1 -DLL_FMOD=1 -DLL_OPENAL=1


Attachments:
File comment: Sun without PBR
Sun_wo_PBR.jpg
Sun_wo_PBR.jpg [ 6.1 KiB | Viewed 6290 times ]
File comment: Sun with PBR
Sun_w_PBR.jpg
Sun_w_PBR.jpg [ 5.93 KiB | Viewed 6290 times ]
File comment: Log file
CoolVLViewer.zip [30.86 KiB]
Downloaded 161 times
Author:  ZaneZimer [ 2024-01-15 15:11:48 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
Rez cloud images:

Attachments:
File comment: Rez cloud without PBR
Rez_Cloud_wo_PBR.jpg
Rez_Cloud_wo_PBR.jpg [ 11.19 KiB | Viewed 6289 times ]
File comment: Rez cloud with PBR
Rez_Cloud_w_PBR.jpg
Rez_Cloud_w_PBR.jpg [ 23.22 KiB | Viewed 6289 times ]
Author:  Henri Beauchamp [ 2024-01-15 15:16:37 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
These are not "bugs" but render discrepancies between two different renderers (the legacy one, and LL's new PBR one). There is strictly nothing I can (or would) do on my side about them.

If you are not happy with how LL's PBR viewer renders SL, do feel free to open JIRA (or rather Canny, now/soon) issues about them, using LL's own viewer for the screen shots in PBR mode (so that they won't take the fact you are using a TPV as an excuse to disregard your issue).

LL decided to push to release a viewer that was barely at beta state... They will have to endure the consequences and fix their stuff by themselves now !
Author:  ZaneZimer [ 2024-01-15 15:19:30 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
I was just about to redownload and look at the official viewer in Wine. I didn't know if these might also be related to other render discrepancies you have noted before, Henri.
Author:  ZaneZimer [ 2024-01-15 18:23:44 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
As a follow on, installing Second Life Release 7.1.2.7215179142 (64bit) and running via Wine doesn't show the issue with the sun image. It does, however, have the issue with avatar 'rez cloud' particles. This may be related to this, as noted by a Mole: PBR Bug - Alpha Transparancy on Water issue. I have added a comment to note the issue also seems to affect the 'rez cloud' particles.
Author:  Henri Beauchamp [ 2024-01-15 19:03:28 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
ZaneZimer wrote:
Second Life Release 7.1.2.7215179142 (64bit) and running via Wine doesn't show the issue with the sun image.
The Cool VL Viewer got changes that have been done in the viewer sources git, but have not yet been released (I even had to revert part of those changes, since they broke the avatar preview), so yes, you will see differences with the current official release viewer...

As for the Sun and Moon discs, one of the recent changes was about their altitude, to make them render in front of the stars; for the Sun disc, this does not make much sense anyway, since when the Sun is showing, the stars are not rendering... This likely also caused the Sun disc to render in front of the Sun glow. To fix this, change the app_settings/shaders/pbr/class1/deferred/sunDiscV.glsl file in the installation directory to read, line 47 and 48:
Code:
    // Render the Sun disc behind the Sun glow. HB
    pos.z = pos.z*1.00001;

Instead of:
Code:
    // smash to *almost* far clip plane -- behind clouds but in front of stars
    pos.z = pos.w*0.999999;
Author:  ZaneZimer [ 2024-01-15 19:20:38 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
Henri Beauchamp wrote:
Code:
    // Render the Sun disc behind the Sun glow. HB
    pos.z = pos.z*1.00001;

Instead of:
Code:
    // smash to *almost* far clip plane -- behind clouds but in front of stars
    pos.z = pos.w*0.999999;

Is it really pos.z versus the original pos.w? If I use the change above, the sun disc now flickers as the camera angle changes. Somewhat like when two object faces intersect at the same coordinates.

*edit: using pos.w and the new factor works though.
Author:  Henri Beauchamp [ 2024-01-15 19:32:39 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
ZaneZimer wrote:
Is it really pos.z versus the original pos.w? If I use the change above, the sun disc now flickers as the camera angle changes.
No, pos.w would be in the 4th dimension... and indeed looks like a bug by LL. :P

ZaneZimer wrote:
If I use the change above, the sun disc now flickers as the camera angle changes.
Floating point error/rounding issue... Use a slightly larger factor: 1.0001 should do fine with all drivers and GPUs (all GPUs do not use the same floating point representation).
Author:  ZaneZimer [ 2024-01-15 19:43:53 ]
Post subject:  Re: PBR and sun/avatar 'rez cloud' issue?
I thought the .w coordinate part would be odd but noted in the .glsl file was a vec4, and just chalked it up to logic I didn't understand. The slightly larger value does work, on the .z part.
Page 1 of 1 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/