Cool VL Viewer forum

View unanswered posts | View active topics It is currently 2024-09-16 00:11:59



Reply to topic  [ 10 posts ] 
Crash while overwriting local texture that is applied 
Author Message

Joined: 2015-02-09 19:41:55
Posts: 17
Reply with quote
Platform: Windows 11

Steps to reproduce:

1) Create and save a new image (in Krita or Photoshop for example)
2) Log in with the viewer, rez a cube and load and apply the image as local texture
3) In your image editor, change the image a bit and overwrite the file
The viewer will instantly crash

Notes:
- not particular to which image editor is used
- file formats tried: png with and without alpha, tga, jpg
- source drive/partition doesn't matter (c: or d:)
- number of opengl worker threads and image decode thread (tried auto and both to 1)
- happens in SL and OpenSim (0.9.3 git)


Attachments:
File comment: version, dump, logs
local-texture-overwrite.zip [38.95 KiB]
Downloaded 40 times
2024-06-11 14:25:49
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
I cannot reproduce this bug here, but thanks to your crash dump I could pinpoint the place where it could indeed encounter and wrongly use a NULL pointer, based on what your avatar is wearing (or rather not wearing)...

LL's code is especially dirty in LLLocalBitmap::updateUserLayers() (where the viewer tries and detects whether the local texture you changed is used in your avatar's wearable items or not, to update it there when it is in use), and needs NULL checks.

I fixed the code for next release, so hopefully it will solve this crash for you...

EDIT: I sent you the link to a test binary in PM. Please give it a try and let me know if it fixes the crash for you...


2024-06-11 15:06:44
Profile WWW

Joined: 2015-02-09 19:41:55
Posts: 17
Reply with quote
Unfortunately the test build bombs out too using the reproduction steps above.

Attached is another dump/log


Attachments:
dump.zip [39.62 KiB]
Downloaded 41 times
2024-06-13 12:28:06
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
Well, that's very unfortunate, and extremely surprising ! :?

Sadly, I did not keep the symbols file for the test build, so the crash dump is useless... I will make another test build for you, and will keep the symbols file, this time. Please reproduce the error with that new test build (will send a PM to you for the link) and provide the corresponding crash dump.

EDIT: test build link sent in PM.


2024-06-13 13:06:09
Profile WWW

Joined: 2015-02-09 19:41:55
Posts: 17
Reply with quote
2 sessions

In session 1 i was clouded and the world was grey (maybe because previous session ended bad), however I was able to test and couldn't reproduce the bug in this report, and the overwritten texture was displayed correct on the cube (no crash). I logged out cleanly. The log says there where problems getting capabilities (among which GetMesh), idk if related.

In session 2 the world looked ok and normal, but I was able to reproduce the bug again resulting in a crash, like my initial report.

See zipfile


Attachments:
crashdump.zip [58.94 KiB]
Downloaded 43 times
2024-06-13 14:02:53
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
The crash dumps you provide are still the ones associated with v1.32.0.26: you are not running the test viewer !

From the corresponding log file:
Code:
2024-06-13 13:48:27Z INFO: LLAppViewer::writeSystemInfo: Cool VL Viewer version 1.32.0.26
2024-06-13 13:48:27Z INFO: LLAppViewer::writeSystemInfo: Local time: 2024-06-13T15:48:27 W. Europe Daylight Time

Please, unzip the test build archive somewhere (in Documents, for example); open the test build folder, and double-click on the CoolVLViewer.exe executable file there; that viewer build is v1.32.2.0 (check it the About floater).


2024-06-13 14:25:44
Profile WWW

Joined: 2015-02-09 19:41:55
Posts: 17
Reply with quote
Ha sorry you're right my mistake for session 2 I ran the last release per accident.

Ok new (crash) session on test-build-2


Attachments:
logs.zip [39.41 KiB]
Downloaded 38 times
2024-06-13 14:34:59
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
Thank you !

Found the bug (typo: wrong index used inside a loop "i" instead of "j"), which indeed can cause crashes depending on what your avatar is wearing (max number of wearable layers), thus why you won't see the crash while a cloud, or when wearing at most one wearable layer of any wearable types...

Fixed for next release. I sent a link to you in PM to a third test build, just for (paranoid) confirmation...


2024-06-13 15:03:14
Profile WWW

Joined: 2015-02-09 19:41:55
Posts: 17
Reply with quote
I can confirm it works now.

Thank you so much :)


2024-06-13 15:22:25
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
Fixed release (v1.32.2.0) published today.


2024-06-15 12:34:55
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   [ 10 posts ] 

Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software.