Cool VL Viewer forum

View unanswered posts | View active topics It is currently 2024-09-15 23:57:13



Reply to topic  [ 3 posts ] 
No Shader bound crash on startup/login? 
Author Message

Joined: 2011-10-07 10:39:20
Posts: 196
Reply with quote
Hello Henri,

no idea if this is a significant issue.

When starting after some the viewer got killed by a TerminateProcess by accidentially clicking in the wrong row in ProcessExplorer, the next start greeted me with a message box and a crash. So there might have been some state on disk corrupted by previous actions.

Log & dump attached.


Attachments:
noshader.zip [54.1 KiB]
Downloaded 42 times
2024-06-30 18:18:20
Profile

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
Hmm... Very strange, indeed.

Looking at the log (no shader compilation failure), the crash dump and at the corresponding code,I see nothing wrong, and the shader should have been bound before the LLVertexBuffer::setBuffer() call which threw this error.

For next release, I added a check in LLFace where LLVertexBuffer::setBuffer() is called, to check that a shader is indeed bound before calling it, and otherwise warn and abort the corresponding object render...

EDIT: in fact, yes, there is something wrong in the code, where the Moon shader is not bound (but used) when the Moon texture cannot load... Seeing how the viewer was failing to load textures and contact the server (inventory AIS errors, etc) in your log, I won't be surprised if this is what indeed happened. Fixed for next release (if you want to fix it in the current sources, simply remove the silly if() test around line 710 of indra/newview/lldrawpoolwlsky.cpp: sMoonShader->bind(); must be called unconditionally).


2024-06-30 19:09:52
Profile WWW

Joined: 2009-03-17 18:42:51
Posts: 5772
Reply with quote
Fixed in today's release (v1.32.2.3).


2024-07-06 09:02:16
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   [ 3 posts ] 

Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software.