Cool VL Viewer forum - View topic - No bound shader crash on certain RLV restrictions

View unanswered posts | View active topics

It is currently 2025-02-13 10:06:52

No bound shader crash on certain RLV restrictions

Page 1 of 1

[ 6 posts ]

Print view

Previous topic | Next topic

No bound shader crash on certain RLV restrictions

Author

Message

wired

Joined: 2009-06-08 16:33:20
Posts: 36

No bound shader crash on certain RLV restrictions

Hi, using Cool Viewer 1.32.2.x has introduced a bug someday in conjunction with BPR, i see a crash on 1.32.2.16 but also saw it on earlier versions, i cant exactly tell when it has been introduced, sorry.

This happens when PBR is active and view Texture Restriction is applied, then it instantly crashes with "No bound shader !" message.
It does not happen in non PBR mode though.

I can reproduce it with your official provided binary, as well as with my own gcc14 or clang18 compiled binaries.

You can try it yourself for example with the ideeen Prison Suit when applying texture restriction or with the Z&A Expulsion Suit, the very moment it is locked the viewer crashes instantly! (Some texture restrictions are applied automatically on lock)

I added the log and crash dump below

If you need any further information just let me know.


	Attachments: Viewer_log.zip [19.66 KiB] Downloaded 168 times

2024-09-28 17:21:01

Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5912

Re: No bound shader crash on certain RLV restrictions

I think I found the bug (which got introduced with the latest changes to PBR terrain rendering).

Since you are using Linux, maybe you can compile the viewer yourself ? In which case, you could try and edit linden/indra/newview/lldrawpoolterrain.cpp, from line 1109 to read:


	Code: void LLDrawPoolTerrain::renderSimple() { // *Note: due to PBR terrain rendering changes, the shader is not bound // any more in beginDeferredPass() for PBR, and renderSimple() can be // called in this mode due to RLV restrictions. HB if (gUsePBRShaders && LLGLSLShader::sCurBoundShaderPtr != sShader) { sShader->bind(); } LLVector4 tp0, tp1; .../...

Then compile the viewer (*), and let me know if it fixes the crash for you...

(*) If you never did it, see linden/doc/LinuxBuildHowto.txt. Compiling the viewer is very straightforward and easy under Linux.

2024-09-28 17:53:46

wired

Joined: 2009-06-08 16:33:20
Posts: 36

Re: No bound shader crash on certain RLV restrictions

Hi,

thank you, yes that fixed it!

Include it in your next version please.

2024-09-28 19:33:11

Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5912

Re: No bound shader crash on certain RLV restrictions


	wired wrote: Include it in your next version please.

It was already the case, of course...

2024-09-28 22:40:29

Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5912

Re: No bound shader crash on certain RLV restrictions

Fixed in today's v1.32.2.17 release.

2024-10-05 08:40:27

wired

Joined: 2009-06-08 16:33:20
Posts: 36

Re: No bound shader crash on certain RLV restrictions

thank you, i can confirm it works "out of the box" now

2024-10-05 11:52:59

Page 1 of 1

[ 6 posts ]

Who is online

Users browsing this forum: No registered users and 156 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum