Cool VL Viewer forum

View unanswered posts | View active topics It is currently 2021-10-20 16:14:05



Reply to topic  [ 3 posts ] 
Possible bug with item links patch 
Author Message

Joined: 2010-09-21 20:19:25
Posts: 2
Reply with quote
I noticed that you've got
Code:
@@ -4276,7 +4608,7 @@
          {
             if ( gGestureManager.isGestureActive( gest_item_array.get(i)->getUUID()) )
             {
-               gGestureManager.deactivateGesture( gest_item_array.get(i)->getUUID() );
+               gGestureManager.deactivateGesture( gest_item_array.get(i)->getLinkedUUID());
                gInventory.updateItem( gest_item_array.get(i) );
                gInventory.notifyObservers();
             }
@@ -4299,21 +4631,36 @@


Shouldn't the check be
Code:
if ( gGestureManager.isGestureActive( gest_item_array.get(i)->getLinkedUUID()) )

to actually get to that?


2010-09-21 20:22:09
Profile

Joined: 2009-03-17 18:42:51
Posts: 4751
Reply with quote
In fact, no, it does not introduce a bug, because if you look in llgesturemgr.cpp at BOOL LLGestureManager::isGestureActive(const LLUUID& item_id), the first thing it does is to get the linked UUID (if any) for item_id...

But you are right that it is incoherent (here, actually just useless) to use getLinkedUUID() after the test, since deactivateGesture() also takes care of checking for links by itself. I'll correct this in the next version of the patch.


2010-09-21 22:03:49
Profile WWW

Joined: 2010-09-21 20:19:25
Posts: 2
Reply with quote
Yeah, it was less thinking it would introduce a bug and more just thinking it seemed off than anything. One line in a very large number of lines of code, thought it might've been overlooked.


2010-09-21 22:29:26
Profile
Display posts from previous:  Sort by  
Reply to topic   [ 3 posts ] 

Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software.