Cool VL Viewer forum

Heyas, noticed a bug in lltexturecache.cpp, in the 1.25 viewer, leading to a lot of warnings similar to the following:

2010-12-08T09:21:18Z WARNING: LLTextureCacheRemoteWorker::doRead: Error reading file from local cache: C:\Snowglobe\skins\default\textures\7ca39b4c-bd19-4699-aff7-f93fd03d3e7b.j2c Bytes: 131038 Offset: 32768 / 131038

No idea if its in the base snowglobe code or not, but since Snowglobe isn't really supported by LL now anyways, I thought I'd submit the info here. I traced it down to a math error in the local fetch code, they were not taking offsets into consideration when an empty or too big DataSize was requested along with an offset, on local files.

This is a patch against 1.25.0.16

--- lltexturecache.cpp.orig 2010-12-08 04:52:22.742000040 -0500
+++ lltexturecache.cpp 2010-12-08 04:53:55.567000043 -0500
@@ -250,9 +250,9 @@
}
}
#else
- if (!mDataSize || mDataSize > local_size)
+ if (!mDataSize || mDataSize > (local_size-mOffset))
{
- mDataSize = local_size;
+ mDataSize = local_size-mOffset;
}
mReadData = new U8[mDataSize];

Well spotted ! Thank you !

There's also another place in lltexturecache.cpp where mOffset is ignored... It could also explain the (rare) "rainbow textures" issue when HTTP fetching is enabled. I'll do some testing and if all goes well, this fix will be part of the next release.