Cool VL Viewer forum

View unanswered posts | View active topics It is currently 2025-06-17 11:31:28



Reply to topic  [ 2 posts ] 
Options in avatar pie menu sometimes don't work 
Author Message

Joined: 2011-01-08 13:47:21
Posts: 4
Reply with quote
I've been having problems with trying to view people's profiles from the pie menu when right clicking their avatar.
I traced the problem down to LLSelectMgr::removeObjectFromSelections() in newview/llselectmgr.cpp.
What was happening is that if a kill object message was received between opening the pie menu and selecting an option the above mentioned function would remove any avatars from the current selection.
According to the comment in the code it was doing this to deselect any avatars sitting on the object being removed but it didn't check to see if the avatar it was deselecting was actually sitting on the object in question.
This was a problem because the handlers for the menu options used the selection manager to find out which object they needed to act upon.
It appears to be a bug that was in the Linden Viewer1 but has been fixed in Viewer2, as the following line in that function:

else if (object->isAvatar())

now reads:

else if (object->isAvatar() && object->getParent() && ((LLViewerObject*)object->getParent())->mID == id)

I've made that change locally and it appears to be working for me now.


2011-08-11 00:38:37
Profile

Joined: 2009-03-17 18:42:51
Posts: 5995
Reply with quote
You know, I love it when people give solutions to bugs ! ;)

Yes, that annoying bug was introduced somewhere in v1.2x viewers. Glad to see it fixed in v2.

That backport will be part of v1.26.0.14.

Thanks for the pointer ! :)


2011-08-11 08:22:39
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   [ 2 posts ] 

Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software.