Cool VL Viewer forum

Register • FAQ • Search • Login
View unanswered posts | View active topics It is currently 2024-04-19 22:48:23

Board index » Bug reports

All times are UTC




Reply to topic  Page 1 of 1
  [ 10 posts ] 
Print view Previous topic | Next topic 
Attached lights broken in deferred rendering 
Author Message
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post Attached lights broken in deferred rendering
Attached lights only light up objects/textures that have transparency since v1.26.22.60 (and v1.26.22.59) .

At the photo i wear a light emitting sphere attached to my avatar. The left cube is set to transparent by 1%, the right one has no transparency set.

It is also visible at my clothes and the platform: no transparency -> no light gets rendered.

It doesn't happen in non-deferred rendering and also not in v1.26.22.58 and before.


Attachments:
Bildschirmfoto vom 2019-09-15 17-16-53.jpg
Bildschirmfoto vom 2019-09-15 17-16-53.jpg [ 49.7 KiB | Viewed 5956 times ]
2019-09-15 15:39:33
Profile
Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5546
Reply with quote
Post Re: Attached lights broken in deferred rendering
There has been no change about how lights are rendered between the viewer versions you mention... Are you sure you did not simply disable "Attached lights" ?...
2019-09-15 16:15:37
Profile WWW
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post Re: Attached lights broken in deferred rendering
Attached lights are turned on. Surprisingly it happens now also on v1.26.22.58. I didn't change any settings except RenderCullWater. Also the Nvidia driver is still the same. 4 days ago it worked as expected. I will investigate what could happen.
2019-09-15 16:55:34
Profile
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post Re: Attached lights broken in deferred rendering
I tried now v1.26.22.57 and attached lights work as expected. Going back to v1.26.22.58 or v1.26.22.60 breaks it again.

Code:
Cool VL Viewer v1.26.22.60, 64 bits, Sep 15 2019 10:42:36
RestrainedLove viewer v2.09.25.20
Release Notes

CPU: AMD FX-8320E Eight-Core Processor (3379.12 MHz)
Memory: 32132MB
OS version: Linux-x86_64 v5.2.14-1-ck #1 SMP PREEMPT Wed Sep 11 20:08:52 CEST 2019
Memory manager: jemalloc v5.2.1-20190913
Graphics card vendor: NVIDIA Corporation
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2
OpenGL version: 4.6.0 NVIDIA 435.21
Detected VRAM: 6144MB
J2C decoder: OpenJPEG: 1.4.0.635f
Audio driver: FMOD Studio v2.00.04 (PulseAudio)
Networking backend: libcurl/7.47.0 OpenSSL/1.0.2s zlib/1.2.11
Embedded browser: CEF3 plugin v76.1.13+gf19c584+chromium-76.0.3809.132

Built with: GCC v4.8.5
Compiler-generated maths: SSE2.

Compile flags used for this build:
-O3 -fno-delete-null-pointer-checks -fno-align-labels -fno-align-loops -fno-ipa-cp-clone -fsched-pressure -frename-registers -fweb -DNDEBUG -std=c++98 -pipe -g -gdwarf-2 -gstrict-dwarf -fno-var-tracking-assignments -fexceptions -fno-strict-aliasing -fvisibility=hidden -fsigned-char -m64 -mfpmath=sse -fno-math-errno -fno-trapping-math -pthread -fno-stack-protector -Wall -Wno-reorder -Wno-unused-local-typedefs -Werror -DLL_LINUX=1 -D_REENTRANT -D_GLIBCXX_USE_C99_MATH=1 -DXML_STATIC -DLL_USE_JEMALLOC=1 -DLL_ELFBIN=1 -DLL_LUA=1 -DOV_EXCLUDE_STATIC_CALLBACKS -DLL_FMODSTUDIO=1 -DLL_OPENAL=1 -DLL_SDL=1 -DLIB_NDOF=1 -DLL_X11=1


Attachments:
CoolVLViewer.log.gz [6.07 KiB]
Downloaded 270 times
2019-09-15 17:51:20
Profile
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post [fixed] Re: Attached lights broken in deferred rendering
After resetting "UseObjectCacheOcclusion" and "UseOcclusion" to default, issue is fixed. Toggling TRUE/FALSE didn't help and both settings were untouched at TRUE before. It was needed to push the "Reset to default"-button.
2019-09-15 20:20:32
Profile
Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5546
Reply with quote
Post Re: Attached lights broken in deferred rendering
Duncan Armundsen wrote:
I tried now v1.26.22.57 and attached lights work as expected. Going back to v1.26.22.58 or v1.26.22.60 breaks it again.
This could be related to the following change in v1.26.22.58:
Quote:
  • Backported from LL's viewer-neko a fix to "attached light is still visible when it is out of the draw distance"

I'll check it... But since you are using the Linux viewer, you should be able to test it yourself, by changing lines 8577 and below in linden/indra/newview/llpipeline.cpp to read:
Code:
#if 0
                     if (dist_vec(vobj->getPosition(),
                               gViewerCamera.getOrigin()) > RenderFarClip)
                     {
                        continue;
                     }
#endif

And then recompile... This would disable the fix that could cause your issue.
2019-09-15 22:25:34
Profile WWW
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post Re: Attached lights broken in deferred rendering
Yes, after disabling the fix, attached lights work for me again as expected. Thank you! :D
2019-09-16 00:42:00
Profile
Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5546
Reply with quote
Post Re: Attached lights broken in deferred rendering
Good !

Now, it would be great if you could also test the following fix, replacing lines 8569 to 8583 (inclusive) of llpipeline.cpp with:
Code:
                  const LLViewerObject* vobj = drawablep->getVObj();
                  if (vobj)
                  {
                     LLVOAvatar* av = vobj->getAvatar();
                     if (!av) continue;
                     if (!av->isSelf() &&
                        (av->isInMuteList() || av->isTooComplex()))
                     {
                        continue;
                     }
                     if (dist_vec(av->getPosition(),
                               gViewerCamera.getOrigin() > RenderFarClip)
                     {
                        continue;
                     }
                  }
and tell me if it works for you, please...
2019-09-16 09:14:51
Profile WWW
Duncan Armundsen

Joined: 2018-07-14 07:17:42
Posts: 20
Reply with quote
Post Re: Attached lights broken in deferred rendering
Yes, that works!

Only a bracket in line 8580 was missing:
Code:
                               gViewerCamera.getOrigin()) > RenderFarClip)
                                                        ^


Attached lights get rendered as expected :)


Last edited by Duncan Armundsen on 2019-09-16 15:14:24, edited 1 time in total.
2019-09-16 09:48:36
Profile
Henri Beauchamp

Joined: 2009-03-17 18:42:51
Posts: 5546
Reply with quote
Post Re: Attached lights broken in deferred rendering
Thank you !
2019-09-16 10:07:22
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   Page 1 of 1
  [ 10 posts ] 

Board index » Bug reports

All times are UTC


Who is online

Users browsing this forum: No registered users and 94 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software.